Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/ic/handler-compiler.cc

Issue 879213003: Load setter from map descriptor instead of embedding it in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix arm Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-inl.h" 10 #include "src/ic/ic-inl.h"
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 StoreFieldStub stub(isolate(), it->GetFieldIndex(), it->representation()); 435 StoreFieldStub stub(isolate(), it->GetFieldIndex(), it->representation());
436 GenerateTailCall(masm(), stub.GetCode()); 436 GenerateTailCall(masm(), stub.GetCode());
437 437
438 __ bind(&miss); 438 __ bind(&miss);
439 TailCallBuiltin(masm(), MissBuiltin(kind())); 439 TailCallBuiltin(masm(), MissBuiltin(kind()));
440 return GetCode(kind(), Code::FAST, it->name()); 440 return GetCode(kind(), Code::FAST, it->name());
441 } 441 }
442 442
443 443
444 Handle<Code> NamedStoreHandlerCompiler::CompileStoreViaSetter( 444 Handle<Code> NamedStoreHandlerCompiler::CompileStoreViaSetter(
445 Handle<JSObject> object, Handle<Name> name, Handle<JSFunction> setter) { 445 Handle<JSObject> object, Handle<Name> name, int accessor_index,
446 Frontend(name); 446 int expected_arguments) {
447 GenerateStoreViaSetter(masm(), type(), receiver(), setter); 447 Register holder = Frontend(name);
448 GenerateStoreViaSetter(masm(), type(), receiver(), holder, accessor_index,
449 expected_arguments);
448 450
449 return GetCode(kind(), Code::FAST, name); 451 return GetCode(kind(), Code::FAST, name);
450 } 452 }
451 453
452 454
453 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 455 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
454 Handle<JSObject> object, Handle<Name> name, 456 Handle<JSObject> object, Handle<Name> name,
455 const CallOptimization& call_optimization) { 457 const CallOptimization& call_optimization) {
456 Frontend(name); 458 Frontend(name);
457 GenerateApiAccessorCall(masm(), call_optimization, handle(object->map()), 459 GenerateApiAccessorCall(masm(), call_optimization, handle(object->map()),
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 DCHECK(elements_kind == DICTIONARY_ELEMENTS); 491 DCHECK(elements_kind == DICTIONARY_ELEMENTS);
490 cached_stub = LoadDictionaryElementStub(isolate()).GetCode(); 492 cached_stub = LoadDictionaryElementStub(isolate()).GetCode();
491 } 493 }
492 } 494 }
493 495
494 handlers->Add(cached_stub); 496 handlers->Add(cached_stub);
495 } 497 }
496 } 498 }
497 } 499 }
498 } // namespace v8::internal 500 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698