Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 878873002: Add a close box to flights-app toast. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a close box to flights-app toast. This is to get a case of having an outline on an absolutely positioned, overflow:hidden, i.e. a self-painting layer. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ffcbc3b2f5417b09328eae4aeb8de2e5eab6324d

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M sky/examples/flights-app/app-toast.sky View 1 2 chunks +13 lines, -0 lines 0 comments Download
M sky/tests/framework/flights-app-pixels-expected.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ojan
Committed patchset #2 (id:20001) manually as ffcbc3b2f5417b09328eae4aeb8de2e5eab6324d (presubmit successful).
5 years, 11 months ago (2015-01-27 06:54:44 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-27 06:58:06 UTC) #3
blundell
5 years, 11 months ago (2015-01-27 09:30:16 UTC) #5
Message was sent while issue was closed.
FYI, I reverted this CL in https://codereview.chromium.org/880863002:

    This test broke sky_tests:
    
    Regressions: Unexpected text-only failures (6)
      framework/flights-app.sky [ Failure ]
    
    Example:
    
   
http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20ASan%20%28dbg...

Powered by Google App Engine
This is Rietveld 408576698