Issue 880863002: Revert "Add a close box to flights-app toast."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880863002: Revert "Add a close box to flights-app toast." (Closed)

Created:
5 years, 11 months ago by blundell

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Add a close box to flights-app toast." This reverts commit ffcbc3b2f5417b09328eae4aeb8de2e5eab6324d. This test broke sky_tests: Regressions: Unexpected text-only failures (6) framework/flights-app.sky [ Failure ] Example: http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20ASan%20%28dbg%29/builds/173/steps/Sky%20tests/logs/stdio TBR=ojan Committed: https://chromium.googlesource.com/external/mojo/+/4a6c9d4dd8b920d6355fe395fe0af571ea6d5872

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -14 lines)			Patch
	M	sky/examples/flights-app/app-toast.sky	View		2 chunks	+0 lines, -13 lines	0 comments	Download
	M	sky/tests/framework/flights-app-pixels-expected.sky	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

blundell

5 years, 11 months ago (2015-01-27 09:11:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4a6c9d4dd8b920d6355fe395fe0af571ea6d5872 (presubmit successful).