Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 878813003: [Extensions Toolbar] Ensure popup is closed at shutdown (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Ensure popup is closed at shutdown Since the popup close process is asynchronous, it's possible that the popup doesn't close by the time the platform delegate is deleted. If that's the case, we need to be sure to close it, so that we do our cleanup (like removing ourselves as an observer). BUG=454361 Committed: https://crrev.com/30c6bd2ea49196c896dc3d43475d1a1744b529f8 Cr-Commit-Position: refs/heads/master@{#314352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Please take a look when you have time. :)
5 years, 10 months ago (2015-02-03 16:17:53 UTC) #2
Finnur
LGTM
5 years, 10 months ago (2015-02-03 16:29:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878813003/1
5 years, 10 months ago (2015-02-03 16:43:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 16:46:38 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:47:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30c6bd2ea49196c896dc3d43475d1a1744b529f8
Cr-Commit-Position: refs/heads/master@{#314352}

Powered by Google App Engine
This is Rietveld 408576698