Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

Issue 878813003: [Extensions Toolbar] Ensure popup is closed at shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
diff --git a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
index be345846cc50554f81ab9816e9228b8e68cd64b3..fcc3f7ae7d1861cbc15553de96f6edc4e50e53f3 100644
--- a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
+++ b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
@@ -69,6 +69,10 @@ ExtensionActionPlatformDelegateViews::~ExtensionActionPlatformDelegateViews() {
DCHECK(!popup_); // We should never have a visible popup at shutdown.
if (context_menu_owner == this)
context_menu_owner = nullptr;
+ // Since the popup close process is asynchronous, it might not be fully closed
+ // at shutdown. We still need to cleanup, though.
+ if (popup_)
+ CleanupPopup(true);
UnregisterCommand(false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698