Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878673005: Get rid of Chrome, use Page. (Closed)

Created:
5 years, 10 months ago by esprehn
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Get rid of Chrome, use Page. This hides ChromeClient inside Page and gets rid of Chrome object. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2cb8f606200ed138f1412821b0b2090fc4133597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -453 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/InputMethodController.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/frame/Console.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/core/frame/Frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/Frame.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/frame/FrameConsole.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameHost.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 4 chunks +2 lines, -15 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/AutoscrollController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/page/Chrome.h View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/engine/core/page/Chrome.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 2 chunks +2 lines, -41 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/FocusController.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M sky/engine/core/page/Page.h View 6 chunks +35 lines, -6 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 4 chunks +76 lines, -3 lines 0 comments Download
M sky/engine/core/page/PageAnimator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 2 chunks +1 line, -13 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 5 chunks +0 lines, -26 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/SpellCheckerClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.h View 3 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-01-27 01:11:54 UTC) #2
esprehn
5 years, 10 months ago (2015-01-27 02:06:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2cb8f606200ed138f1412821b0b2090fc4133597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698