sky/engine/core/editing/InputMethodController.cpp - Issue 878673005: Get rid of Chrome, use Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/InputMethodController.cpp

Issue 878673005: Get rid of Chrome, use Page. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/InputMethodController.cpp

diff --git a/sky/engine/core/editing/InputMethodController.cpp b/sky/engine/core/editing/InputMethodController.cpp

index e61869fc3e40826ecded9bd4b164ee71e46fe50c..b96e985314c83713b33d545f17ddc58dc695bfc4 100644

--- a/sky/engine/core/editing/InputMethodController.cpp

+++ b/sky/engine/core/editing/InputMethodController.cpp

@@ -35,7 +35,6 @@

#include "sky/engine/core/editing/TypingCommand.h"

#include "sky/engine/core/events/CompositionEvent.h"

#include "sky/engine/core/frame/LocalFrame.h"

-#include "sky/engine/core/page/Chrome.h"

#include "sky/engine/core/page/ChromeClient.h"

#include "sky/engine/core/page/EventHandler.h"

#include "sky/engine/core/rendering/RenderObject.h"

@@ -140,11 +139,7 @@ bool InputMethodController::confirmCompositionOrInsertText(const String& text, C

void InputMethodController::confirmCompositionAndResetState()

{

- if (!hasComposition())

- return;

- // ChromeClient::willSetInputMethodState() resets input method and the composition string is committed.

- m_frame.chromeClient().willSetInputMethodState();

+ // TODO(esprehn): Remove this.

}

void InputMethodController::cancelComposition()

« no previous file with comments | « sky/engine/core/editing/EditorCommand.cpp ('k') | sky/engine/core/frame/Console.cpp » ('j') | no next file with comments »