Handle Caps Lock for Ozone.

Handle Caps Lock for Ozone.

BUG=447277
Committed: https://crrev.com/8a5ce90e69b39e9e5a0decb278008dc3e7a85cb7
Cr-Commit-Position: refs/heads/master@{#313341}

[kpschoedel, 2015-01-26 20:31:07]

kpschoedel@chromium.org changed reviewers:
+ shuchen@chromium.org, spang@chromium.org

[spang, 2015-01-26 20:34:34]

https://codereview.chromium.org/878673004/diff/1/ui/events/ozone/evdev/keyboa...
File ui/events/ozone/evdev/keyboard_evdev.cc (right):

https://codereview.chromium.org/878673004/diff/1/ui/events/ozone/evdev/keyboa...
ui/events/ozone/evdev/keyboard_evdev.cc:88:
UpdateModifier(ui::EF_CAPS_LOCK_DOWN, enabled);
Don't think this is right. You probably need a new function

EventModifiersEvdev::SetModifierLock(unsigned int modifier, bool locked) {
  DCHECK_LT(modifier, EVDEV_NUM_MODIFIERS);

  if (locked)
    modifier_flags_locked_ |= kEventFlagFromModifiers[modifier];
  else
    modifier_flags_locked_ &= ~kEventFlagFromModifiers[modifier];
  
  UpdateFlags(modifier);
}

[Shu Chen, 2015-01-27 03:51:10]

https://codereview.chromium.org/878673004/diff/1/ui/base/ime/chromeos/ime_key...
File ui/base/ime/chromeos/ime_keyboard_ozone.cc (right):

https://codereview.chromium.org/878673004/diff/1/ui/base/ime/chromeos/ime_key...
ui/base/ime/chromeos/ime_keyboard_ozone.cc:38:
ImeKeyboard::SetCapsLockEnabled(enable_caps_lock);
Please add comment that this is for notifying capslock state changes.

[Shu Chen, 2015-01-27 03:51:41]

lgtm for changes of ui/base/ime/chromeos/ime_keyboard_ozone.cc.

[kpschoedel, 2015-01-27 17:04:56]

Patchset #2 (id:20001) has been deleted

[kpschoedel, 2015-01-27 17:12:48]

kpschoedel@chromium.org changed reviewers:
+ derat@chromium.org

[kpschoedel, 2015-01-27 17:12:49]

+derat@ for chrome/browser/chromeos/events/event_rewriter.cc

https://codereview.chromium.org/878673004/diff/1/ui/base/ime/chromeos/ime_key...
File ui/base/ime/chromeos/ime_keyboard_ozone.cc (right):

https://codereview.chromium.org/878673004/diff/1/ui/base/ime/chromeos/ime_key...
ui/base/ime/chromeos/ime_keyboard_ozone.cc:38:
ImeKeyboard::SetCapsLockEnabled(enable_caps_lock);
On 2015/01/27 03:51:10, Shu Chen wrote:
> Please add comment that this is for notifying capslock state changes.

Done.

https://codereview.chromium.org/878673004/diff/1/ui/events/ozone/evdev/keyboa...
File ui/events/ozone/evdev/keyboard_evdev.cc (right):

https://codereview.chromium.org/878673004/diff/1/ui/events/ozone/evdev/keyboa...
ui/events/ozone/evdev/keyboard_evdev.cc:88:
UpdateModifier(ui::EF_CAPS_LOCK_DOWN, enabled);
On 2015/01/26 20:34:34, spang wrote:
> Don't think this is right. You probably need a new function
> 
> EventModifiersEvdev::SetModifierLock(unsigned int modifier, bool locked) {
>   DCHECK_LT(modifier, EVDEV_NUM_MODIFIERS);
> 
>   if (locked)
>     modifier_flags_locked_ |= kEventFlagFromModifiers[modifier];
>   else
>     modifier_flags_locked_ &= ~kEventFlagFromModifiers[modifier];
>   
>   UpdateFlags(modifier);
> }

Redone.

[Daniel Erat, 2015-01-27 17:16:59]

lgtm for event_rewriter.cc

[spang, 2015-01-27 19:21:20]

lgtm!

[kpschoedel, 2015-01-27 19:35:42]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/878673004/60001

[commit-bot: I haz the power, 2015-01-27 20:20:28]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-01-27 20:21:46]

Patchset 3 (id:??) landed as
https://crrev.com/8a5ce90e69b39e9e5a0decb278008dc3e7a85cb7
Cr-Commit-Position: refs/heads/master@{#313341}