Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 878653004: Add a flag to flush the canvases during SkMultiPictureDraw::draw(). (Closed)

Created:
5 years, 10 months ago by Stephen White
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a flag to flush the canvases during SkMultiPictureDraw::draw(). This is necessary for multisampling, so that each multisampled render target resolves before Chrome's compositor attempts to draw the texture. BUG=skia: Committed: https://skia.googlesource.com/skia/+/772604c214e8c12ee16d2eb60f4b7acbcdd2129e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M include/core/SkMultiPictureDraw.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Stephen White
PTAL.
5 years, 10 months ago (2015-01-27 18:54:39 UTC) #2
bsalomon
On 2015/01/27 18:54:39, Stephen White wrote: > PTAL. where does the resolve happen? Do we ...
5 years, 10 months ago (2015-01-27 20:24:59 UTC) #3
Stephen White
On 2015/01/27 20:24:59, bsalomon wrote: > On 2015/01/27 18:54:39, Stephen White wrote: > > PTAL. ...
5 years, 10 months ago (2015-01-27 20:28:34 UTC) #4
Stephen White
On 2015/01/27 20:28:34, Stephen White wrote: > On 2015/01/27 20:24:59, bsalomon wrote: > > On ...
5 years, 10 months ago (2015-01-27 20:30:30 UTC) #5
bsalomon
On 2015/01/27 20:30:30, Stephen White wrote: > On 2015/01/27 20:28:34, Stephen White wrote: > > ...
5 years, 10 months ago (2015-01-28 14:39:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878653004/1
5 years, 10 months ago (2015-01-28 15:43:24 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:01:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/772604c214e8c12ee16d2eb60f4b7acbcdd2129e

Powered by Google App Engine
This is Rietveld 408576698