Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 878623004: NaCl: Remove the IRT's Gyp dependency on libsrpc (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Remove the IRT's Gyp dependency on libsrpc Since I removed the IRT's calls to NaClSrpcModuleInit() and NaClPluginLowLevelInitializationComplete(), the IRT no longer depends on SRPC. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=build Committed: https://crrev.com/65a326a734d413e2124c6782b2e32a81ceca74c1 Cr-Commit-Position: refs/heads/master@{#313664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M ppapi/native_client/native_client.gyp View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-01-28 16:14:21 UTC) #2
teravest
lgtm
5 years, 10 months ago (2015-01-28 16:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878623004/1
5 years, 10 months ago (2015-01-29 04:10:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 04:14:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65a326a734d413e2124c6782b2e32a81ceca74c1 Cr-Commit-Position: refs/heads/master@{#313664}
5 years, 10 months ago (2015-01-29 04:16:08 UTC) #7
Mark Seaborn
5 years, 10 months ago (2015-02-05 18:08:20 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/901053008/ by mseaborn@chromium.org.

The reason for reverting is: SRPC will be required by an upcoming NaCl change..

Powered by Google App Engine
This is Rietveld 408576698