Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 878603005: Reenable -Wl,-z,defs on mipsel (Closed)

Created:
5 years, 11 months ago by tbarzic
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable -Wl,-z,defs on mipsel The flags were disabled to suppress a build error in ffmpeg. The error should be fixed now: https://crrev.com/a458f95e5718918a70506be2a33ea3be55e59024 BUG=450771, 371125 TEST=emerge-mipsel-o32-generic chromeos-chrome cbuildbot --remote mipsel-o32-generic-tot-chromium-pfq-informational Committed: https://crrev.com/4f79c115cae3f007a52eab70f614ab3c9b95f011 Cr-Commit-Position: refs/heads/master@{#313180}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
cros tryserver looks happy with this :) (http://chromegw.corp.google.com/i/chromiumos.tryserver/builders/mipsel-o32-generic-tot-chromium-pfq-informational/builds/0)
5 years, 11 months ago (2015-01-26 22:58:36 UTC) #2
Nico
awesome, lgtm. Thanks :-)
5 years, 11 months ago (2015-01-26 23:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878603005/20001
5 years, 11 months ago (2015-01-26 23:02:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 00:38:56 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 00:40:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f79c115cae3f007a52eab70f614ab3c9b95f011
Cr-Commit-Position: refs/heads/master@{#313180}

Powered by Google App Engine
This is Rietveld 408576698