Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: build/config/compiler/BUILD.gn

Issue 878603005: Reenable -Wl,-z,defs on mipsel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 255a2cd0a9750e5c3b514cb59f6383d577fb2857..ff518d97aa68c53ac5d953ae4e340c7abe0045a6 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -350,10 +350,7 @@ config("compiler") {
"-Wl,-z,now",
"-Wl,-z,relro",
]
-
- # TODO(zork): The mipsel build is broken in ffmpeg, guard this flag for now
- # to hide the breakage. https://crbug.com/450771
- if (!using_sanitizer && cpu_arch != "mipsel") {
+ if (!using_sanitizer) {
ldflags += [ "-Wl,-z,defs" ]
}
}
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698