Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878593002: Add docs on how to get a preview of markdown pages. (Closed)

Created:
5 years, 11 months ago by jcgregorio
Modified:
5 years, 10 months ago
Reviewers:
hcm
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add docs on how to get a preview of markdown pages. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1d124c3142acf1a678de9c3f3189bf0c56d32a39

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M site/dev/tools/markdown.md View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
jcgregorio
5 years, 11 months ago (2015-01-26 15:05:09 UTC) #2
hcm
On 2015/01/26 15:05:09, jcgregorio wrote: lgtm
5 years, 11 months ago (2015-01-26 15:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878593002/1
5 years, 11 months ago (2015-01-26 15:16:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1d124c3142acf1a678de9c3f3189bf0c56d32a39
5 years, 11 months ago (2015-01-26 15:24:05 UTC) #6
tfarina
5 years, 10 months ago (2015-01-28 16:43:42 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/878593002/diff/1/site/dev/tools/markdown.md
File site/dev/tools/markdown.md (right):

https://codereview.chromium.org/878593002/diff/1/site/dev/tools/markdown.md#n...
site/dev/tools/markdown.md:14: https://skia.org?cl=REITVELD_ISSUE_NUMBER
Doing just that does not work.

For example, navigating to https://skia.org/?cl=878593002, you are directed to
the Overview page.

But if you navigate to https://skia.org/dev/tools/markdown?cl=878593002 then it
will render the preview of this change.

https://codereview.chromium.org/883003004

Powered by Google App Engine
This is Rietveld 408576698