Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 883003004: Fix the URL for previewing Markdown changes. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix the URL for previewing Markdown changes. BUG=None R=jcgregorio@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/3b7f7b092c8233a651248da8f23e1cfc85ac829b

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M site/dev/tools/markdown.md View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (5 generated)
tfarina
https://skia.org/dev/tools/markdown?cl=883003004
5 years, 10 months ago (2015-01-28 16:43:26 UTC) #1
tfarina
Ping?
5 years, 10 months ago (2015-01-30 14:26:28 UTC) #2
jcgregorio
On 2015/01/30 14:26:28, tfarina wrote: > Ping? Needs to be rebaselined.
5 years, 10 months ago (2015-02-02 17:28:21 UTC) #3
tfarina
On 2015/02/02 17:28:21, jcgregorio wrote: > On 2015/01/30 14:26:28, tfarina wrote: > > Ping? > ...
5 years, 10 months ago (2015-02-03 02:12:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/20001
5 years, 10 months ago (2015-02-03 19:54:10 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-03 19:54:10 UTC) #7
hcm
On 2015/02/03 19:54:10, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 10 months ago (2015-02-03 20:36:10 UTC) #8
tfarina
On 2015/02/03 20:36:10, hcm wrote: > On 2015/02/03 19:54:10, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-03 20:43:48 UTC) #10
tfarina
Done!
5 years, 10 months ago (2015-02-03 20:43:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/40001
5 years, 10 months ago (2015-02-03 20:44:10 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-03 20:44:11 UTC) #14
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-04 02:44:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/40001
5 years, 10 months ago (2015-02-04 13:07:26 UTC) #18
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-04 13:07:27 UTC) #19
jcgregorio
lgtm
5 years, 10 months ago (2015-02-04 14:04:11 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 14:06:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3b7f7b092c8233a651248da8f23e1cfc85ac829b

Powered by Google App Engine
This is Rietveld 408576698