|
|
Created:
5 years, 10 months ago by tfarina Modified:
5 years, 10 months ago Reviewers:
jcgregorio CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix the URL for previewing Markdown changes.
BUG=None
R=jcgregorio@google.com
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/3b7f7b092c8233a651248da8f23e1cfc85ac829b
Patch Set 1 #Patch Set 2 : REBASE #Patch Set 3 : fix typo #Messages
Total messages: 21 (5 generated)
Ping?
On 2015/01/30 14:26:28, tfarina wrote: > Ping? Needs to be rebaselined.
On 2015/02/02 17:28:21, jcgregorio wrote: > On 2015/01/30 14:26:28, tfarina wrote: > > Ping? > > Needs to be rebaselined. Done.
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/20001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 01:54 UTC
On 2015/02/03 19:54:10, I haz the power (commit-bot) wrote: > Note for Reviewers: > The CQ is waiting for an approval. > If you believe that the CL is not ready yet, or if you would like to L-G-T-M > with comments then please uncheck the CQ checkbox. > > Waiting for LGTM from valid reviewer(s) till 2015-02-04 01:54 UTC Thiago, I noticed a small typo "markdow" in the URL should be "markdown" :)
The CQ bit was unchecked by hcm@google.com
On 2015/02/03 20:36:10, hcm wrote: > On 2015/02/03 19:54:10, I haz the power (commit-bot) wrote: > > Note for Reviewers: > > The CQ is waiting for an approval. > > If you believe that the CL is not ready yet, or if you would like to L-G-T-M > > with comments then please uncheck the CQ checkbox. > > > > Waiting for LGTM from valid reviewer(s) till 2015-02-04 01:54 UTC > > Thiago, I noticed a small typo "markdow" in the URL should be "markdown" :)
Done!
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 02:44 UTC
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full Skia committer from https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883003004/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-04 19:07 UTC
lgtm
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/3b7f7b092c8233a651248da8f23e1cfc85ac829b |