Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878523003: Add embedder test for stream length beyond end of file. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, olsen
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add embedder test for stream length beyond end of file. This was fixed by https://codereview.chromium.org/743263002, but the bug remained open due to confusion. BUG=https://code.google.com/p/pdfium/issues/detail?id=57 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/506e6dc4649803ab56ef60d73d9a896f1876a7e6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A fpdfsdk/src/fpdftext_embeddertest.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/bug_57.in View 1 chunk +48 lines, -0 lines 0 comments Download
A testing/resources/bug_57.pdf View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, Olsen, please take a look.
5 years, 10 months ago (2015-01-27 20:15:24 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/878523003/diff/1/fpdfsdk/src/fpdftext_embeddertest.cpp File fpdfsdk/src/fpdftext_embeddertest.cpp (right): https://codereview.chromium.org/878523003/diff/1/fpdfsdk/src/fpdftext_embeddertest.cpp#newcode5 fpdfsdk/src/fpdftext_embeddertest.cpp:5: #include <limits> not needed? ditto for string.
5 years, 10 months ago (2015-01-27 20:23:52 UTC) #3
Tom Sepez
On 2015/01/27 20:23:52, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/878523003/diff/1/fpdfsdk/src/fpdftext_embeddertest.cpp > File fpdfsdk/src/fpdftext_embeddertest.cpp (right): ...
5 years, 10 months ago (2015-01-27 20:27:17 UTC) #4
Tom Sepez
5 years, 10 months ago (2015-01-27 20:30:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
506e6dc4649803ab56ef60d73d9a896f1876a7e6 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698