Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 743263002: Fix blank page issues caused by too strict check (Closed)

Created:
6 years, 1 month ago by jun_fang
Modified:
6 years, 1 month ago
Reviewers:
Tom Sepez, Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix blank page issues caused by too strict check Before this fix, PDF parser aborts the parsering process when detecting an error. For this case, PDF parser just gives up parsering when it detects that the length of image stream is incorrect. The solution to this case is to find the tag "endstream" and "endobj" to calculate the length rather than aborting the parsering process. BUG=433339 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ef619d0562b39f30943cfdc4985a0df233d00e42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jun_fang
Hi guys, please review this change. Thanks!
6 years, 1 month ago (2014-11-20 19:03:39 UTC) #2
Tom Sepez
lgtm
6 years, 1 month ago (2014-11-20 19:09:13 UTC) #3
jun_fang
6 years, 1 month ago (2014-11-20 21:43:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef619d0562b39f30943cfdc4985a0df233d00e42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698