Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 878103002: Revert of Continue learning for calls in optimized code when we have no type feedback. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@navier
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Continue learning for calls in optimized code when we have no type feedback. (patchset #4 id:60001 of https://codereview.chromium.org/868453005/) Reason for revert: Serializer tests broke. Need to debug and fix. Original issue's description: > Continue learning for calls in optimized code when we have no type feedback. > > Based on CL https://codereview.chromium.org/871063002/ which needs to land first. > > BUG= > > Committed: https://crrev.com/f5f2692b5ff70ac3cd06a903b7846174b97a2e55 > Cr-Commit-Position: refs/heads/master@{#26292} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f605f1c2239f254cbef65ce3149fb2e4cf02dcd7 Cr-Commit-Position: refs/heads/master@{#26293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -295 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +3 lines, -9 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -23 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +3 lines, -9 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -23 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +7 lines, -21 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -23 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +3 lines, -9 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +5 lines, -30 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -23 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +3 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Created Revert of Continue learning for calls in optimized code when we have no type ...
5 years, 11 months ago (2015-01-27 13:06:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878103002/1
5 years, 11 months ago (2015-01-27 13:06:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 13:07:02 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 13:07:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f605f1c2239f254cbef65ce3149fb2e4cf02dcd7
Cr-Commit-Position: refs/heads/master@{#26293}

Powered by Google App Engine
This is Rietveld 408576698