Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: src/hydrogen.cc

Issue 878103002: Revert of Continue learning for calls in optimized code when we have no type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@navier
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 54007c524a6cd376a357770eaeaaa28b6e04af8f..b59f5c79494117a109f487f0fc09baad83229167 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -9348,19 +9348,7 @@
Push(graph()->GetConstantUndefined());
CHECK_ALIVE(VisitExpressions(expr->arguments()));
PushArgumentsFromEnvironment(argument_count);
- HCallFunction* call_function =
- New<HCallFunction>(function, argument_count);
- call = call_function;
- if (expr->is_uninitialized() && expr->HasCallFeedbackSlot()) {
- // We've never seen this call before, so let's have Crankshaft learn
- // through the type vector.
- Handle<SharedFunctionInfo> current_shared =
- function_state()->compilation_info()->shared_info();
- Handle<TypeFeedbackVector> vector =
- handle(current_shared->feedback_vector(), isolate());
- FeedbackVectorICSlot slot = expr->CallFeedbackSlot();
- call_function->SetVectorAndSlot(vector, slot);
- }
+ call = New<HCallFunction>(function, argument_count);
}
}
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698