chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@local_vs_federated

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | chrome/browser/ui/passwords/manage_passwords_test.h » ('j') | components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index a69d75cc400baba6de89d137f20963f192f4d326..42c99c5de6e74d247cd053a5a34fa37369e41f6d 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -210,6 +210,7 @@ bool ChromePasswordManagerClient::PromptUserToSavePassword(

bool ChromePasswordManagerClient::PromptUserToChooseCredentials(

const std::vector<autofill::PasswordForm*>& local_forms,

const std::vector<autofill::PasswordForm*>& federated_forms,

+ const GURL& origin,

base::Callback<void(const password_manager::CredentialInfo&)> callback) {

// Take ownership of all the password form objects in the forms vectors.

ScopedVector<autofill::PasswordForm> local_entries;

@@ -220,7 +221,7 @@ bool ChromePasswordManagerClient::PromptUserToChooseCredentials(

ManagePasswordsUIController* manage_passwords_ui_controller =

ManagePasswordsUIController::FromWebContents(web_contents());

return manage_passwords_ui_controller->OnChooseCredentials(

- local_entries.Pass(), federated_entries.Pass(), callback);

+ local_entries.Pass(), federated_entries.Pass(), origin, callback);

}