components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc - Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@local_vs_federated

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc ('k') | components/password_manager/content/browser/credential_manager_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

index 8bc72d008c8eba0670a5c7762315e57484a31bfa..0cc7205fe5dbd19279e452eb0ee3b2025cf9d607 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

@@ -54,6 +54,7 @@ class TestPasswordManagerClient

bool PromptUserToChooseCredentials(

const std::vector<autofill::PasswordForm*>& local_forms,

const std::vector<autofill::PasswordForm*>& federated_forms,

+ const GURL& origin,

base::Callback<void(const password_manager::CredentialInfo&)> callback)

override {

// TODO(melandory): Use ScopedVector instead of std::vector in arguments.

@@ -66,7 +67,7 @@ class TestPasswordManagerClient

ScopedVector<autofill::PasswordForm> federated_entries;

federated_entries.assign(federated_forms.begin(), federated_forms.end());

password_manager::CredentialInfo info(

- local_forms.empty() ? *federated_forms[0] : *local_entries[0],

+ local_forms.empty() ? *federated_forms[0] : *local_forms[0],

Mike West 2015/02/02 14:38:24 Good catch.

local_forms.empty()

? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED

: password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);