Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI (Closed)

Created:
5 years, 11 months ago by melandory
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@local_vs_federated
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Credential Manager API] Pass origin to Account chooser UI BUG=400674 R=mkwst@chromium.org Committed: https://crrev.com/c9f3fa9588c0914862690cad7c8a469d696b3174 Cr-Commit-Position: refs/heads/master@{#315595}

Patch Set 1 : Work in progress. #

Patch Set 2 : Rebased on top of master. #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Rebased #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_test.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_client.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/stub_password_manager_client.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/stub_password_manager_client.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Mike West
Is this still WIP, or are you waiting on me to review? :)
5 years, 10 months ago (2015-01-28 12:22:33 UTC) #1
melandory
On 2015/01/28 12:22:33, Mike West wrote: > Is this still WIP, or are you waiting ...
5 years, 10 months ago (2015-01-28 12:38:20 UTC) #2
melandory
On 2015/01/28 12:38:20, melandory wrote: > On 2015/01/28 12:22:33, Mike West wrote: > > Is ...
5 years, 10 months ago (2015-02-02 14:13:58 UTC) #3
Mike West
LGTM!
5 years, 10 months ago (2015-02-02 14:38:04 UTC) #4
Mike West
https://codereview.chromium.org/877613004/diff/40001/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc File components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc (right): https://codereview.chromium.org/877613004/diff/40001/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc#newcode70 components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc:70: local_forms.empty() ? *federated_forms[0] : *local_forms[0], Good catch.
5 years, 10 months ago (2015-02-02 14:38:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613004/40001
5 years, 10 months ago (2015-02-04 16:16:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/30513)
5 years, 10 months ago (2015-02-04 16:19:52 UTC) #11
melandory
On 2015/02/04 16:19:52, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-05 16:29:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613004/120001
5 years, 10 months ago (2015-02-10 18:27:55 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years, 10 months ago (2015-02-10 18:32:44 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 18:33:23 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c9f3fa9588c0914862690cad7c8a469d696b3174
Cr-Commit-Position: refs/heads/master@{#315595}

Powered by Google App Engine
This is Rietveld 408576698