chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 877613004: [Credential Manager API] Pass origin to Account chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@local_vs_federated

Patch Set: Rebased. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('k') | components/password_manager/content/browser/credential_manager_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 02c78128d140aa562df53bca7bb6d920a2ac2df7..a82dc281235f012cae900100817a22689a2d999a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -260,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, ChooseCredential) {

GURL avatar_url("https://google.com/avatar.png");

test_form()->avatar_url = avatar_url;

local_credentials.push_back(new autofill::PasswordForm(*test_form()));

+ GURL origin("https://example.com");

// Prepare to capture the network request.

TestURLFetcherCallback url_callback;

net::FakeURLFetcherFactory factory(

@@ -272,7 +272,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, ChooseCredential) {

EXPECT_CALL(url_callback, OnRequestDone(avatar_url));

SetupChooseCredentials(local_credentials.Pass(),

- ScopedVector<autofill::PasswordForm>());

+ ScopedVector<autofill::PasswordForm>(), origin);

EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

EXPECT_CALL(*this, OnChooseCredential(

Field(&password_manager::CredentialInfo::type,