Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 877473005: Add device space "nudge" to gpu draws

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add device space "nudge" to gpu draws This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too. BUG=423834 Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78 Committed: https://skia.googlesource.com/skia/+/b9329991426d0b77ea194a380d72d73fb855308a

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Apply clip shader offset on CPU #

Patch Set 4 : Fix comments #

Patch Set 5 : fix bug #

Patch Set 6 : Remove 'f' from GL shader #

Patch Set 7 : Move from 0.05 nudge to 0.003 #

Patch Set 8 : Fix 'f' again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -83 lines) Patch
M samplecode/SampleClipDrawMatch.cpp View 1 7 chunks +66 lines, -59 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 2 3 4 5 6 7 3 chunks +16 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 3 4 5 6 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
robertphillips
5 years, 11 months ago (2015-01-27 18:58:28 UTC) #2
bsalomon
lgtm. Do you think we have adequate gm coverage (my gut is yes). I'd be ...
5 years, 11 months ago (2015-01-27 20:23:59 UTC) #3
robertphillips
I think GM coverage is all right. The new SampleApp slide is great b.c. it ...
5 years, 11 months ago (2015-01-27 20:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877473005/70001
5 years, 10 months ago (2015-01-28 12:46:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877473005/70001
5 years, 10 months ago (2015-01-28 22:41:49 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:70001) as https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
5 years, 10 months ago (2015-01-28 22:42:00 UTC) #10
robertphillips
A revert of this CL (patchset #5 id:70001) has been created in https://codereview.chromium.org/888483003/ by robertphillips@google.com. ...
5 years, 10 months ago (2015-01-29 01:33:07 UTC) #11
robertphillips
A revert of this CL (patchset #5 id:70001) has been created in https://codereview.chromium.org/890433003/ by robertphillips@google.com. ...
5 years, 10 months ago (2015-01-29 01:36:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877473005/90001
5 years, 10 months ago (2015-01-30 19:19:16 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:90001) as https://skia.googlesource.com/skia/+/b9329991426d0b77ea194a380d72d73fb855308a
5 years, 10 months ago (2015-01-30 19:24:54 UTC) #15
robertphillips
5 years, 10 months ago (2015-01-30 22:43:31 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:90001) has been created in
https://codereview.chromium.org/886153002/ by robertphillips@google.com.

The reason for reverting is: Blink layout tests this time :(.

Powered by Google App Engine
This is Rietveld 408576698