Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3861)

Unified Diff: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove Browser* dependency from ExclusiveAccess* in Cocoa. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h
diff --git a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h
index 0b13e6c47b01299d13a138b20cdcf048a2a75704..68ecb8341d0bdc165e1de9f64a59f2d752cc1f5f 100644
--- a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h
+++ b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h
@@ -8,8 +8,8 @@
#include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
#include "url/gurl.h"
-@class BrowserWindowController;
-class Browser;
+class ExclusiveAccessManager;
+class Profile;
@class GTMUILocalizerAndLayoutTweaker;
// The ExclusiveAccessBubbleWindowController manages the bubble that informs the
@@ -19,8 +19,9 @@ class Browser;
@interface ExclusiveAccessBubbleWindowController
: NSWindowController<NSTextViewDelegate, NSAnimationDelegate> {
@private
- BrowserWindowController* owner_; // weak
- Browser* browser_; // weak
+ NSWindowController* owner_; // weak
+ ExclusiveAccessManager* exclusive_access_manager_; // weak
+ Profile* profile_; // weak
GURL url_;
ExclusiveAccessBubbleType bubbleType_;
@@ -42,10 +43,11 @@ class Browser;
};
// Initializes a new InfoBarController.
-- (id)initWithOwner:(BrowserWindowController*)owner
- browser:(Browser*)browser
- url:(const GURL&)url
- bubbleType:(ExclusiveAccessBubbleType)bubbleType;
+- (id)initWithOwner:(NSWindowController*)owner
+ exclusive_access_manager:(ExclusiveAccessManager*)exclusive_access_manager
+ profile:(Profile*)profile
+ url:(const GURL&)url
+ bubbleType:(ExclusiveAccessBubbleType)bubbleType;
- (void)allow:(id)sender;
- (void)deny:(id)sender;

Powered by Google App Engine
This is Rietveld 408576698