chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 877413004: Refactor away the Browser* dependency in exclusive_access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Browser* dependency from ExclusiveAccess* in Cocoa. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h » ('j') | chrome/browser/ui/exclusive_access/exclusive_access_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index 1ed775b94c712b877308ada24d4dcebdcec701d6..625937455b9fd670b72ef486cb0bb73e382e6ea3 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -616,10 +616,11 @@ willPositionSheet:(NSWindow*)sheet

[exclusiveAccessBubbleWindowController_ closeImmediately];

exclusiveAccessBubbleWindowController_.reset(

[[ExclusiveAccessBubbleWindowController alloc]

- initWithOwner:self

- browser:browser_.get()

- url:fullscreenUrl_

- bubbleType:exclusiveAccessBubbleType_]);

+ initWithOwner:self

+ exclusive_access_manager:browser_.get()->exclusive_access_manager()

+ profile:browser_.get()->profile()

+ url:fullscreenUrl_

+ bubbleType:exclusiveAccessBubbleType_]);

[exclusiveAccessBubbleWindowController_ showWindow];

}