Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 877343003: Fix register aliasing after r26306, r26275. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix register aliasing after r26306, r26275. BUG= Committed: https://crrev.com/d83a2445a2ec7ac2f68b50775c452ba627a2e8b6 Cr-Commit-Position: refs/heads/master@{#26317}

Patch Set 1 #

Patch Set 2 : More precise #

Patch Set 3 : Assertions #

Total comments: 2

Patch Set 4 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -36 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 3 chunks +13 lines, -5 lines 0 comments Download
M src/ic/handler-compiler.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 3 chunks +13 lines, -5 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 2 3 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ulan
5 years, 10 months ago (2015-01-28 18:35:50 UTC) #2
ulan
PTAL
5 years, 10 months ago (2015-01-28 19:26:35 UTC) #3
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/877343003/diff/40001/src/ic/ia32/handler-compiler-ia32.cc File src/ic/ia32/handler-compiler-ia32.cc (right): https://codereview.chromium.org/877343003/diff/40001/src/ic/ia32/handler-compiler-ia32.cc#newcode256 src/ic/ia32/handler-compiler-ia32.cc:256: // Do not overwrite receiver ...
5 years, 10 months ago (2015-01-29 08:43:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877343003/60001
5 years, 10 months ago (2015-01-29 09:07:59 UTC) #6
ulan
Thanks! https://codereview.chromium.org/877343003/diff/40001/src/ic/ia32/handler-compiler-ia32.cc File src/ic/ia32/handler-compiler-ia32.cc (right): https://codereview.chromium.org/877343003/diff/40001/src/ic/ia32/handler-compiler-ia32.cc#newcode256 src/ic/ia32/handler-compiler-ia32.cc:256: // Do not overwrite receiver register, it can ...
5 years, 10 months ago (2015-01-29 09:08:07 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-29 09:37:30 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 09:37:44 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d83a2445a2ec7ac2f68b50775c452ba627a2e8b6
Cr-Commit-Position: refs/heads/master@{#26317}

Powered by Google App Engine
This is Rietveld 408576698