Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 877343003: Fix register aliasing after r26306, r26275. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
11 #include "src/ic/ic.h" 11 #include "src/ic/ic.h"
12 12
13 namespace v8 { 13 namespace v8 {
14 namespace internal { 14 namespace internal {
15 15
16 #define __ ACCESS_MASM(masm) 16 #define __ ACCESS_MASM(masm)
17 17
18 18
19 void NamedLoadHandlerCompiler::GenerateLoadViaGetter( 19 void NamedLoadHandlerCompiler::GenerateLoadViaGetter(
20 MacroAssembler* masm, Handle<HeapType> type, Register receiver, 20 MacroAssembler* masm, Handle<HeapType> type, Register receiver,
21 Register holder, int accessor_index, int expected_arguments) { 21 Register holder, int accessor_index, int expected_arguments,
22 Register scratch) {
22 { 23 {
23 FrameScope scope(masm, StackFrame::INTERNAL); 24 FrameScope scope(masm, StackFrame::INTERNAL);
24 25
25 if (accessor_index >= 0) { 26 if (accessor_index >= 0) {
27 DCHECK(!holder.is(scratch));
28 DCHECK(!receiver.is(scratch));
26 // Call the JavaScript getter with the receiver on the stack. 29 // Call the JavaScript getter with the receiver on the stack.
27 if (IC::TypeToMap(*type, masm->isolate())->IsJSGlobalObjectMap()) { 30 if (IC::TypeToMap(*type, masm->isolate())->IsJSGlobalObjectMap()) {
28 // Swap in the global receiver. 31 // Swap in the global receiver.
29 __ mov(receiver, 32 __ mov(scratch,
30 FieldOperand(receiver, JSGlobalObject::kGlobalProxyOffset)); 33 FieldOperand(receiver, JSGlobalObject::kGlobalProxyOffset));
34 receiver = scratch;
31 } 35 }
32 __ push(receiver); 36 __ push(receiver);
33 ParameterCount actual(0); 37 ParameterCount actual(0);
34 ParameterCount expected(expected_arguments); 38 ParameterCount expected(expected_arguments);
35 __ LoadAccessor(edi, holder, accessor_index, ACCESSOR_GETTER); 39 __ LoadAccessor(edi, holder, accessor_index, ACCESSOR_GETTER);
36 __ InvokeFunction(edi, expected, actual, CALL_FUNCTION, 40 __ InvokeFunction(edi, expected, actual, CALL_FUNCTION,
37 NullCallWrapper()); 41 NullCallWrapper());
38 } else { 42 } else {
39 // If we generate a global code snippet for deoptimization only, remember 43 // If we generate a global code snippet for deoptimization only, remember
40 // the place to continue after deoptimization. 44 // the place to continue after deoptimization.
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 Immediate(the_hole)); 228 Immediate(the_hole));
225 } else { 229 } else {
226 __ cmp(Operand::ForCell(cell), Immediate(the_hole)); 230 __ cmp(Operand::ForCell(cell), Immediate(the_hole));
227 } 231 }
228 __ j(not_equal, miss); 232 __ j(not_equal, miss);
229 } 233 }
230 234
231 235
232 void NamedStoreHandlerCompiler::GenerateStoreViaSetter( 236 void NamedStoreHandlerCompiler::GenerateStoreViaSetter(
233 MacroAssembler* masm, Handle<HeapType> type, Register receiver, 237 MacroAssembler* masm, Handle<HeapType> type, Register receiver,
234 Register holder, int accessor_index, int expected_arguments) { 238 Register holder, int accessor_index, int expected_arguments,
239 Register scratch) {
235 // ----------- S t a t e ------------- 240 // ----------- S t a t e -------------
236 // -- esp[0] : return address 241 // -- esp[0] : return address
237 // ----------------------------------- 242 // -----------------------------------
238 { 243 {
239 FrameScope scope(masm, StackFrame::INTERNAL); 244 FrameScope scope(masm, StackFrame::INTERNAL);
240 245
241 // Save value register, so we can restore it later. 246 // Save value register, so we can restore it later.
242 __ push(value()); 247 __ push(value());
243 248
244 if (accessor_index >= 0) { 249 if (accessor_index >= 0) {
250 DCHECK(!holder.is(scratch));
251 DCHECK(!receiver.is(scratch));
252 DCHECK(!value().is(scratch));
245 // Call the JavaScript setter with receiver and value on the stack. 253 // Call the JavaScript setter with receiver and value on the stack.
246 if (IC::TypeToMap(*type, masm->isolate())->IsJSGlobalObjectMap()) { 254 if (IC::TypeToMap(*type, masm->isolate())->IsJSGlobalObjectMap()) {
247 // Swap in the global receiver. 255 __ mov(scratch,
248 __ mov(receiver,
249 FieldOperand(receiver, JSGlobalObject::kGlobalProxyOffset)); 256 FieldOperand(receiver, JSGlobalObject::kGlobalProxyOffset));
257 receiver = scratch;
250 } 258 }
251 __ push(receiver); 259 __ push(receiver);
252 __ push(value()); 260 __ push(value());
253 ParameterCount actual(1); 261 ParameterCount actual(1);
254 ParameterCount expected(expected_arguments); 262 ParameterCount expected(expected_arguments);
255 __ LoadAccessor(edi, holder, accessor_index, ACCESSOR_SETTER); 263 __ LoadAccessor(edi, holder, accessor_index, ACCESSOR_SETTER);
256 __ InvokeFunction(edi, expected, actual, CALL_FUNCTION, 264 __ InvokeFunction(edi, expected, actual, CALL_FUNCTION,
257 NullCallWrapper()); 265 NullCallWrapper());
258 } else { 266 } else {
259 // If we generate a global code snippet for deoptimization only, remember 267 // If we generate a global code snippet for deoptimization only, remember
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 // Return the generated code. 764 // Return the generated code.
757 return GetCode(kind(), Code::NORMAL, name); 765 return GetCode(kind(), Code::NORMAL, name);
758 } 766 }
759 767
760 768
761 #undef __ 769 #undef __
762 } 770 }
763 } // namespace v8::internal 771 } // namespace v8::internal
764 772
765 #endif // V8_TARGET_ARCH_IA32 773 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/handler-compiler.cc ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698