Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 877253002: Ensure ExternalSurface is idle in fullscreen video mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 2b75e3bab66fc1b9943323787f465ae608a9b307..055bf79c392a207d1cd2b3a6a3fc3fcd90a81636 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -321,13 +321,16 @@ void BrowserMediaPlayerManager::DetachExternalVideoSurface(int player_id) {
}
void BrowserMediaPlayerManager::OnFrameInfoUpdated() {
Hugo Holgersson 2015/01/29 15:24:18 I added a print here. In fullscreen video playback
+ if (fullscreen_player_id_ != kInvalidMediaPlayerId)
+ return;
+
if (external_video_surface_container_)
external_video_surface_container_->OnFrameInfoUpdated();
}
void BrowserMediaPlayerManager::OnNotifyExternalSurface(
int player_id, bool is_request, const gfx::RectF& rect) {
- if (!web_contents_)
+ if (!web_contents_ || fullscreen_player_id_ != kInvalidMediaPlayerId)
qinmin 2015/01/28 19:31:04 What happens if we exit fullscreen? The external s
william.xie1 2015/01/28 23:33:22 Hi Min, if we exit fullscreen, the external surfac
qinmin 2015/02/02 17:45:07 what if user wrote a script to scroll the page whi
return;
if (is_request) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698