Ensure ExternalSurface is idle in fullscreen video mode

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
@@ skipping 302 matching lines @@
         gfx::ScopedJavaSurface::AcquireExternalSurface(surface));
   }
 }
 
 void BrowserMediaPlayerManager::DetachExternalVideoSurface(int player_id) {
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player)
     player->SetVideoSurface(gfx::ScopedJavaSurface());
 }
 
 void BrowserMediaPlayerManager::OnFrameInfoUpdated() {

[Hugo Holgersson, 2015/01/29 15:24:18]

I added a print here. In fullscreen video playback, OnFrameInfoUpdated() runs
once the info layer updates (second ticks/progress bar advances/fades in/out).
OnFrameInfoUpdated() does not run at all in a paused state.

To make this clear, in the CL description I'd rather write: "When the progress
layer updates itself (second ticks/progress bar advances/fades in/out) on top of
fullscreen video playback, we do not need to send OnFrameInfoUpdated() to video
hole surface because it is hidden behind the fullscreen surface."

(Tested in com.android.browser with --force-use-overlay-embedded-video.)

+  if (fullscreen_player_id_ != kInvalidMediaPlayerId)
+    return;
+
   if (external_video_surface_container_)
     external_video_surface_container_->OnFrameInfoUpdated();
 }
 
 void BrowserMediaPlayerManager::OnNotifyExternalSurface(
     int player_id, bool is_request, const gfx::RectF& rect) {
-  if (!web_contents_)
+  if (!web_contents_ || fullscreen_player_id_ != kInvalidMediaPlayerId)

[qinmin, 2015/01/28 19:31:04]

What happens if we exit fullscreen? The external surface view will showing up in
a wrong position?

[william.xie1, 2015/01/28 23:33:22]

Hi Min, if we exit fullscreen, the external surface view will show up in the
original position before enter fullscreen, which is the correct behavior. 
This change is target to skip to notify external surface during the process of
entering to full screen (message is sent from
RendererMediaPlayerManager::DidCommitCompositorFrame()).

[qinmin, 2015/02/02 17:45:07]

what if user wrote a script to scroll the page while entering fullscreen?
Shouldn't we update the external surface position if scroll position changes?

     return;
 
   if (is_request) {
     OnRequestExternalSurface(player_id, rect);
   }
   if (external_video_surface_container_) {
     external_video_surface_container_->OnExternalVideoSurfacePositionChanged(
         player_id, rect);
   }
 }
@@ skipping 236 matching lines @@
     external_video_surface_container_->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 void BrowserMediaPlayerManager::ReleasePlayer(MediaPlayerAndroid* player) {
   player->Release();
   ReleaseMediaResources(player->player_id());
 }
 
 }  // namespace content