chrome/browser/ui/search_engines/search_engine_tab_helper.cc - Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/search_engine_tab_helper.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search_engines/search_engine_tab_helper.cc

diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc

index 73d32bc899ad9379ff1748395ed3915ae6bab134..278008cf7dba9b19a3b51bfc2e18f71b926a1463 100644

--- a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc

+++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc

@@ -198,7 +198,8 @@ void SearchEngineTabHelper::GenerateKeywordIfNecessary(

// the later.

// TODO(sky): Need a way to set the favicon that doesn't involve generating

// its url.

- new_url->SetFaviconURL(TemplateURL::GenerateFaviconURL(params.referrer));

+ new_url->SetFaviconURL(

+ TemplateURL::GenerateFaviconURL(params.referrer.url));

}

new_url->set_safe_for_autoreplace(true);

url_service->Add(new_url);