chrome/browser/ui/login/login_prompt_browsertest.cc - Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_prompt_browsertest.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/web_intent_picker_gtk.cc ('k') | chrome/browser/ui/search_engines/search_engine_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/login/login_prompt_browsertest.cc

diff --git a/chrome/browser/ui/login/login_prompt_browsertest.cc b/chrome/browser/ui/login/login_prompt_browsertest.cc

index b3746e05230ed70dcabca7e281b3322e80de134a..60eb95ea3dc03ba6ab5e2f33ae2765ed2ef68225 100644

--- a/chrome/browser/ui/login/login_prompt_browsertest.cc

+++ b/chrome/browser/ui/login/login_prompt_browsertest.cc

@@ -682,13 +682,13 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, SupplyRedundantAuths) {

WindowedAuthNeededObserver auth_needed_waiter_2(controller_2);

contents_1->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/1"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

contents_2->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/2"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

@@ -748,13 +748,13 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, CancelRedundantAuths) {

WindowedAuthNeededObserver auth_needed_waiter_2(controller_2);

contents_1->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/1"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

contents_2->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/2"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

@@ -815,13 +815,13 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest,

controller_incognito);

contents->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/1"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

contents_incognito->tab_contents()->OpenURL(OpenURLParams(

test_server()->GetURL("auth-basic/2"),

- GURL(),

+ content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_TYPED,

false));

« no previous file with comments | « chrome/browser/ui/gtk/web_intent_picker_gtk.cc ('k') | chrome/browser/ui/search_engines/search_engine_tab_helper.cc » ('j') | no next file with comments »