[Password Generation] Fix bug where the same form may not compare as equal

[Password Generation] Fix bug where the same form may not compare as equal

This is because currently the forms we are comparing are saved at slightly
different times and so may be modified in between. This change brings
PasswordGenerationAgent in line with AutofillAgent.

BUG=452741
Committed: https://crrev.com/53a28d0076fdb7011f863f612389c11f83185217
Cr-Commit-Position: refs/heads/master@{#314048}

[Garrett Casto, 2015-01-28 00:59:10]

gcasto@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-01-29 13:33:22]

LGTM, seems reasonable, following the bug's description.

Ideally we would have also a test reproducing the issue from imgur, given if it
is tricky to make the timing right, I don't see it as critical.

Cheers,
Vaclav

[Garrett Casto, 2015-01-31 00:07:30]

On 2015/01/29 13:33:22, vabr (Chromium) wrote:
> LGTM, seems reasonable, following the bug's description.
> 
> Ideally we would have also a test reproducing the issue from imgur, given if
it
> is tricky to make the timing right, I don't see it as critical.
> 
> Cheers,
> Vaclav

Unfortunately a real test for this is a little hard to do as you want to make
sure that what the AutofillAgent and PasswordGenerationAgent are doing is the
same, but for testing we ignore the AutofillAgent since otherwise the test isn't
hermetic. We could add a way to inject a response into the AutofillAgent, but
that's not trivial. I agree that it would be nice though, so I'll comment on the
bug to add a test for this at some point and leave it open.

[Garrett Casto, 2015-01-31 00:08:21]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2015-01-31 00:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/877193004/1

[commit-bot: I haz the power, 2015-01-31 05:47:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-31 05:48:16]

Patchset 1 (id:??) landed as
https://crrev.com/53a28d0076fdb7011f863f612389c11f83185217
Cr-Commit-Position: refs/heads/master@{#314048}