Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 877193004: [Password Generation] Fix bug where the same form may not compare as equal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 AccountCreationFormData( 64 AccountCreationFormData(
65 linked_ptr<PasswordForm> form, 65 linked_ptr<PasswordForm> form,
66 std::vector<blink::WebInputElement> password_elements); 66 std::vector<blink::WebInputElement> password_elements);
67 ~AccountCreationFormData(); 67 ~AccountCreationFormData();
68 }; 68 };
69 69
70 typedef std::vector<AccountCreationFormData> AccountCreationFormDataList; 70 typedef std::vector<AccountCreationFormData> AccountCreationFormDataList;
71 71
72 // RenderFrameObserver: 72 // RenderFrameObserver:
73 void DidFinishDocumentLoad() override; 73 void DidFinishDocumentLoad() override;
74 void DidFinishLoad() override;
75 74
76 // Message handlers. 75 // Message handlers.
77 void OnFormNotBlacklisted(const PasswordForm& form); 76 void OnFormNotBlacklisted(const PasswordForm& form);
78 void OnPasswordAccepted(const base::string16& password); 77 void OnPasswordAccepted(const base::string16& password);
79 void OnAccountCreationFormsDetected( 78 void OnAccountCreationFormsDetected(
80 const std::vector<autofill::FormData>& forms); 79 const std::vector<autofill::FormData>& forms);
81 80
82 // Helper function that will try and populate |password_elements_| and 81 // Helper function that will try and populate |password_elements_| and
83 // |possible_account_creation_form_|. 82 // |possible_account_creation_form_|.
84 void FindPossibleGenerationForm(); 83 void FindPossibleGenerationForm();
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 135
137 // If this feature is enabled. Controlled by Finch. 136 // If this feature is enabled. Controlled by Finch.
138 bool enabled_; 137 bool enabled_;
139 138
140 DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgent); 139 DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgent);
141 }; 140 };
142 141
143 } // namespace autofill 142 } // namespace autofill
144 143
145 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 144 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698