Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 877183002: Make running asanified tests on swarming work on Windows. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make running asanified tests on swarming work on Windows. With swarming, the run command gets baked into the .isolate file instead of going through runtest.py. Usually, an invocation of test_env.py is baked into the isolate file. In asan mode, this used to call asan_symbolize.py, which on Windows doesn't work -- prepend it with sys.executable to make this work on all platforms. BUG=451741 Committed: https://crrev.com/b095146c32074b3a96c89e7be2405c77571fdb58 Cr-Commit-Position: refs/heads/master@{#313360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/test_env.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 11 months ago (2015-01-27 20:51:50 UTC) #2
scottmg
lgtm
5 years, 11 months ago (2015-01-27 20:54:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877183002/1
5 years, 11 months ago (2015-01-27 20:56:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 21:31:46 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 21:32:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b095146c32074b3a96c89e7be2405c77571fdb58
Cr-Commit-Position: refs/heads/master@{#313360}

Powered by Google App Engine
This is Rietveld 408576698