testing/test_env.py - Issue 877183002: Make running asanified tests on swarming work on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_env.py

Issue 877183002: Make running asanified tests on swarming work on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/test_env.py

diff --git a/testing/test_env.py b/testing/test_env.py

index 4c194277bf33090c31097025cf7c85064413a10a..bfb58b821678fb2b9397bcbb6aee93434b3c8f91 100755

--- a/testing/test_env.py

+++ b/testing/test_env.py

@@ -173,7 +173,8 @@ def run_executable(cmd, env):

# Need to pipe to the symbolizer script.

p1 = subprocess.Popen(cmd, env=env, stdout=subprocess.PIPE,

stderr=sys.stdout)

- p2 = subprocess.Popen(["../tools/valgrind/asan/asan_symbolize.py"],

+ p2 = subprocess.Popen([sys.executable,

+ "../tools/valgrind/asan/asan_symbolize.py"],

env=env, stdin=p1.stdout)

p1.stdout.close() # Allow p1 to receive a SIGPIPE if p2 exits.

p1.wait()

« no previous file with comments | « no previous file | no next file » | no next file with comments »