Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 877043002: Remove RenderLayerScrollableArea (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, ojan
CC:
ojan, eseidel, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove RenderLayerScrollableArea This CL is a first step towards removing the scrolling machinery from the engine. Notice that we pay a tax for scrolling in RenderBlockFlow::layout. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8d4f499648c20c57e7f6199bc883993556628b3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1155 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 7 chunks +1 line, -62 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 8 chunks +19 lines, -62 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 9 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 11 chunks +3 lines, -54 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -194 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -697 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-27 08:10:35 UTC) #1
esprehn
lgtm, the tower is falling.
5 years, 11 months ago (2015-01-27 08:25:54 UTC) #3
ojan
lgtm amazing.
5 years, 11 months ago (2015-01-27 10:39:43 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-27 17:58:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8d4f499648c20c57e7f6199bc883993556628b3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698