Issue 876803002: [Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s

Issue 876803002: [Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s (Closed)

Created:
5 years, 11 months ago by nednguyen

Modified:
5 years, 11 months ago

Reviewers:
sullivan, chrishenry

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, telemetry-reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s BUG=448827 Committed: https://crrev.com/c1c4ddd7399bf74e5f42099eebbccbc8f256b7d0 Cr-Commit-Position: refs/heads/master@{#313114}

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 9 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nednguyen

On 2015/01/26 19:07:11, nednguyen wrote: Chris: this should fix the flakiness bug on Mac too, ...

5 years, 11 months ago (2015-01-26 19:07:39 UTC) #3

nednguyen

https://codereview.chromium.org/876803002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py File tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py (right): https://codereview.chromium.org/876803002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py#newcode25 tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py:25: devtools_http_instance.Request('') Reviewers: devtools_http.Request(...) set the default timeout amount to ...

5 years, 11 months ago (2015-01-26 19:08:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876803002/1

5 years, 11 months ago (2015-01-26 19:12:47 UTC) #7

commit-bot: I haz the power

5 years, 11 months ago (2015-01-26 20:22:03 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c1c4ddd7399bf74e5f42099eebbccbc8f256b7d0
Cr-Commit-Position: refs/heads/master@{#313114}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages