tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py - Issue 876803002: [Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

Issue 876803002: [Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

index 96356370ddd6586c93f162d4aa1ca2f1d476a823..4dc7f755b5684ff3e83df506e1f0eef14f454bb2 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

@@ -18,9 +18,11 @@ def IsDevToolsAgentAvailable(port):

return _IsDevToolsAgentAvailable(devtools_http.DevToolsHttp(port))

+# TODO(nednguyen): Find a more reliable way to check whether the devtool agent

+# is still alive.

def _IsDevToolsAgentAvailable(devtools_http_instance):

try:

- devtools_http_instance.Request('', timeout=.1)

+ devtools_http_instance.Request('')

nednguyen 2015/01/26 19:08:29 Reviewers: devtools_http.Request(...) set the defa

except devtools_http.DevToolsClientConnectionError:

return False

else:

« no previous file with comments | « no previous file | no next file » | no next file with comments »