Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 876633009: Revert of Add a parser for Link headers (Closed)

Created:
5 years, 10 months ago by perezju
Modified:
5 years, 10 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add a parser for Link headers (patchset #8 id:140001 of https://codereview.chromium.org/889883002/) Reason for revert: A memory leak was detected by the asan tool. Original issue's description: > Add a parser for Link headers > > This CL adds a parser for Link headers, that would enable to support them for various features that can benefit from such support. Resource Hints (and the non-standard hints: dns-prefetch, prefetch, etc) are likely to be the first users. > > BUG=58456 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189352 TBR=pmeenan@google.com,mkwst@chromium.org,yoav@yoav.ws NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=58456 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -342 lines) Patch
D LayoutTests/http/tests/linkHeader/link-header-no-crash-empty.php View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-empty-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-space-in-url.php View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-space-in-url-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-space-invalid.php View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-space-invalid-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-valid.php View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/linkHeader/link-header-no-crash-valid-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/loader/LinkHeader.h View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/loader/LinkHeader.cpp View 1 chunk +0 lines, -198 lines 0 comments Download
D Source/core/loader/LinkHeaderTest.cpp View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
perezju
Created Revert of Add a parser for Link headers
5 years, 10 months ago (2015-02-03 14:58:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876633009/1
5 years, 10 months ago (2015-02-03 14:59:36 UTC) #2
perezju
Using the address sanitnizer following the instructions here: http://www.chromium.org/developers/testing/addresssanitizer when running webkit_unit_tests we obtain: [ ...
5 years, 10 months ago (2015-02-03 15:00:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189420
5 years, 10 months ago (2015-02-03 15:05:32 UTC) #4
Mike West
5 years, 10 months ago (2015-02-03 15:26:42 UTC) #5
Message was sent while issue was closed.
LGTM, thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698