Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 876633002: Revert of Isolate extensions_browsertests (Closed)

Created:
5 years, 11 months ago by kaliamoorthi
Modified:
5 years, 11 months ago
Reviewers:
Yoyo Zhou, M-A Ruel, scottmg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Isolate extensions_browsertests (patchset #7 id:120001 of https://codereview.chromium.org/869783004/) Reason for revert: This CL seem to cause the failure in extension browser test in Windows Vista SP2 Original issue's description: > Isolate extensions_browsertests > > R=maruel@chromium.org, yoz@chromium.org > TBR=jam@chromium.org > BUG=98637 > > Committed: https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831 > Cr-Commit-Position: refs/heads/master@{#312993} TBR=maruel@chromium.org,yoz@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/c25902f538732f8bcfc651f72c2a5af043e7b9bd Cr-Commit-Position: refs/heads/master@{#313062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -163 lines) Patch
D extensions/extensions_browsertests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +3 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +3 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +2 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +5 lines, -30 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kaliamoorthi
Created Revert of Isolate extensions_browsertests
5 years, 11 months ago (2015-01-26 12:43:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876633002/1
5 years, 11 months ago (2015-01-26 12:44:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 12:45:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c25902f538732f8bcfc651f72c2a5af043e7b9bd Cr-Commit-Position: refs/heads/master@{#313062}
5 years, 11 months ago (2015-01-26 12:46:17 UTC) #4
scottmg
5 years, 11 months ago (2015-01-26 17:48:46 UTC) #5
Message was sent while issue was closed.
Thanks, lgtm. Sorry for leaving it broken so long.

(Need to try all permutations of OS's and Debug/Release when isolating it seems
-- Windows is too sneaky.)

Powered by Google App Engine
This is Rietveld 408576698