Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869783004: Isolate extensions_browsertests (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Yoyo Zhou, M-A Ruel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate extensions_browsertests R=maruel@chromium.org, yoz@chromium.org TBR=jam@chromium.org BUG=98637 Committed: https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831 Cr-Commit-Position: refs/heads/master@{#312993} Committed: https://crrev.com/2e25142f0a30638f60219d90bcc87784ae0c4c4d Cr-Commit-Position: refs/heads/master@{#313209}

Patch Set 1 #

Patch Set 2 : fixes, update buildbot #

Patch Set 3 : . #

Patch Set 4 : cros fix, maybe? #

Patch Set 5 : linux libosmesa #

Total comments: 3

Patch Set 6 : sort conditions #

Patch Set 7 : rebase #

Patch Set 8 : Add wow_helper for Vista x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -30 lines) Patch
A + extensions/extensions_browsertests.isolate View 1 2 3 4 5 6 7 5 chunks +17 lines, -16 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 3 chunks +18 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 3 chunks +18 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 chunks +12 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 5 chunks +30 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
scottmg
5 years, 11 months ago (2015-01-23 23:35:11 UTC) #4
M-A Ruel
lgtm https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate File extensions/extensions_browsertests.isolate (right): https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate#newcode42 extensions/extensions_browsertests.isolate:42: ['OS=="linux" or OS=="mac" or OS=="win"', { FYI, I ...
5 years, 11 months ago (2015-01-24 00:03:07 UTC) #5
scottmg
https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate File extensions/extensions_browsertests.isolate (right): https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate#newcode42 extensions/extensions_browsertests.isolate:42: ['OS=="linux" or OS=="mac" or OS=="win"', { On 2015/01/24 00:03:07, ...
5 years, 11 months ago (2015-01-24 00:24:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869783004/100001
5 years, 11 months ago (2015-01-24 00:25:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/52008) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/3963) ios_rel_device_ninja_ng ...
5 years, 11 months ago (2015-01-24 00:29:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869783004/120001
5 years, 11 months ago (2015-01-24 00:32:47 UTC) #12
M-A Ruel
https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate File extensions/extensions_browsertests.isolate (right): https://codereview.chromium.org/869783004/diff/80001/extensions/extensions_browsertests.isolate#newcode42 extensions/extensions_browsertests.isolate:42: ['OS=="linux" or OS=="mac" or OS=="win"', { On 2015/01/24 00:24:55, ...
5 years, 11 months ago (2015-01-24 00:37:37 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 11 months ago (2015-01-24 02:07:12 UTC) #14
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831 Cr-Commit-Position: refs/heads/master@{#312993}
5 years, 11 months ago (2015-01-24 02:08:13 UTC) #15
Yoyo Zhou
LGTM
5 years, 11 months ago (2015-01-24 04:34:39 UTC) #16
kaliamoorthi
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/876633002/ by kaliamoorthi@chromium.org. ...
5 years, 11 months ago (2015-01-26 12:43:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869783004/140001
5 years, 11 months ago (2015-01-27 00:59:57 UTC) #19
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 11 months ago (2015-01-27 02:41:15 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:42:19 UTC) #21
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/2e25142f0a30638f60219d90bcc87784ae0c4c4d
Cr-Commit-Position: refs/heads/master@{#313209}

Powered by Google App Engine
This is Rietveld 408576698