Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 876603002: Add stack direction heap unit test. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add stack direction heap unit test. Verify that stack usage grows in the expected direction. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
M Source/platform/heap/StackFrameDepth.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-26 07:55:25 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-26 07:56:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876603002/1
5 years, 11 months ago (2015-01-26 08:02:28 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 09:10:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188946

Powered by Google App Engine
This is Rietveld 408576698