Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: Source/platform/heap/StackFrameDepth.h

Issue 876603002: Add stack direction heap unit test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/HeapTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/StackFrameDepth.h
diff --git a/Source/platform/heap/StackFrameDepth.h b/Source/platform/heap/StackFrameDepth.h
index ed43873ed34980243d0dd379160111fb885c86f1..8ad2b9d984d7a542566262f7e828e5d7e0ceb431 100644
--- a/Source/platform/heap/StackFrameDepth.h
+++ b/Source/platform/heap/StackFrameDepth.h
@@ -20,8 +20,11 @@ public:
{
ASSERT(m_stackFrameLimit);
- // Below comparison assumes callstack to glow downward,
- // which is true for all ABI Blink currently supports.
+ // Asssume that the stack grows towards lower addresses, which
+ // all the ABIs currently supported do.
+ //
+ // A unit test checks that the assumption holds for a target
+ // (HeapTest.StackGrowthDirection.)
return currentStackFrame() > m_stackFrameLimit;
}
« no previous file with comments | « Source/platform/heap/HeapTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698