Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 876413007: [Android WebView] Rename ShouldInterceptRequestParams -> AwWebResourceRequest (Closed)

Created:
5 years, 10 months ago by mnaganov (inactive)
Modified:
5 years, 10 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Rename ShouldInterceptRequestParams -> AwWebResourceRequest We will start using these parameters in more callbacks, so it makes sense to rename them into something more generic. BUG=456782 Committed: https://crrev.com/5a82c52529f817246dd56f8a0cec829172a06e7f Cr-Commit-Position: refs/heads/master@{#315378}

Patch Set 1 #

Patch Set 2 : Remove unneeded import #

Patch Set 3 : Fixed glue code #

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 10 months ago (2015-02-09 17:19:49 UTC) #2
sgurun-gerrit only
On 2015/02/09 17:19:49, mnaganov (cr) wrote: lgtm
5 years, 10 months ago (2015-02-09 19:07:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876413007/40001
5 years, 10 months ago (2015-02-09 20:13:17 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 20:40:38 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 20:41:24 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5a82c52529f817246dd56f8a0cec829172a06e7f
Cr-Commit-Position: refs/heads/master@{#315378}

Powered by Google App Engine
This is Rietveld 408576698