android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 876413007: [Android WebView] Rename ShouldInterceptRequestParams -> AwWebResourceRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 876413007: [Android WebView] Rename ShouldInterceptRequestParams -> AwWebResourceRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed glue code Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index 27fe68c96414f786617366be6708416f6b66b2d4..043bb326954f06e7c043de84c0186b1a8ad4c0cb 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -22,7 +22,6 @@ import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;

import org.apache.http.Header;

import org.apache.http.HttpRequest;

import org.chromium.android_webview.AwContents;

-import org.chromium.android_webview.AwContentsClient.ShouldInterceptRequestParams;

import org.chromium.android_webview.AwSettings;

import org.chromium.android_webview.AwWebResourceResponse;

import org.chromium.android_webview.test.util.CommonResources;

@@ -2739,9 +2738,8 @@ public class AwSettingsTest extends AwTestBase {

final String defaultVideoPosterUrl = "http://default_video_poster/";

TestAwContentsClient client = new TestAwContentsClient() {

@Override

- public AwWebResourceResponse shouldInterceptRequest(

- ShouldInterceptRequestParams params) {

- if (params.url.equals(defaultVideoPosterUrl)) {

+ public AwWebResourceResponse shouldInterceptRequest(AwWebResourceRequest request) {

+ if (request.url.equals(defaultVideoPosterUrl)) {

videoPosterAccessedCallbackHelper.notifyCalled();

}

return null;