Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4395)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 876343004: fix autofill shadowing vars warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index b14193aee695d082d2e9aae680d71dde508a8fea..f0797350b524baa3a8df13dbcd122f627a017993 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -743,8 +743,8 @@ TEST_F(AutofillDialogControllerTest, PhoneNumberValidation) {
const DetailInputs& inputs =
controller()->RequestedFieldsForSection(section);
AutofillProfile full_profile(test::GetVerifiedProfile());
- for (size_t i = 0; i < inputs.size(); ++i) {
- const ServerFieldType type = inputs[i].type;
+ for (size_t ix = 0; ix < inputs.size(); ++ix) {
Ilya Sherman 2015/01/28 01:35:48 nit: Please use 'j' instead of 'ix'
+ const ServerFieldType type = inputs[ix].type;
outputs[type] = full_profile.GetInfo(AutofillType(type), "en-US");
}
@@ -2966,10 +2966,10 @@ TEST_F(AutofillDialogControllerTest, InputEditability) {
controller()->OnDidGetWalletItems(items.Pass());
EXPECT_TRUE(controller()->IsEditingExistingData(SECTION_CC_BILLING));
- const DetailInputs& inputs =
- controller()->RequestedFieldsForSection(SECTION_CC_BILLING);
FieldValueMap outputs;
- CopyInitialValues(inputs, &outputs);
+ CopyInitialValues(
+ controller()->RequestedFieldsForSection(SECTION_CC_BILLING),
+ &outputs);
controller()->GetView()->SetUserInput(SECTION_CC_BILLING, outputs);
for (size_t i = 0; i < arraysize(sections); ++i) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698