fix autofill shadowing vars warning

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 725 matching lines @@
     ServerFieldType phone = i == 0 ? PHONE_HOME_WHOLE_NUMBER :
                                      PHONE_BILLING_WHOLE_NUMBER;
     ServerFieldType address = i == 0 ? ADDRESS_HOME_COUNTRY :
                                        ADDRESS_BILLING_COUNTRY;
     DialogSection section = i == 0 ? SECTION_SHIPPING : SECTION_BILLING;
 
     FieldValueMap outputs;
     const DetailInputs& inputs =
         controller()->RequestedFieldsForSection(section);
     AutofillProfile full_profile(test::GetVerifiedProfile());
-    for (size_t i = 0; i < inputs.size(); ++i) {
-      const ServerFieldType type = inputs[i].type;
+    for (size_t ix = 0; ix < inputs.size(); ++ix) {

[Ilya Sherman, 2015/01/28 01:35:48]

nit: Please use 'j' instead of 'ix'

+      const ServerFieldType type = inputs[ix].type;
       outputs[type] = full_profile.GetInfo(AutofillType(type), "en-US");
     }
 
     // Make sure country is United States.
     outputs[address] = ASCIIToUTF16("United States");
 
     // Existing data should have no errors.
     ValidityMessages messages = controller()->InputsAreValid(section, outputs);
     EXPECT_FALSE(HasAnyError(messages, phone));
 
@@ skipping 2201 matching lines @@
   }
 
   // Expired instrument: CC number + CVV are not editable.
   items = wallet::GetTestWalletItems(wallet::AMEX_DISALLOWED);
   scoped_ptr<wallet::WalletItems::MaskedInstrument> expired_instrument =
       wallet::GetTestMaskedInstrumentExpired();
   items->AddInstrument(expired_instrument.Pass());
   controller()->OnDidGetWalletItems(items.Pass());
   EXPECT_TRUE(controller()->IsEditingExistingData(SECTION_CC_BILLING));
 
-  const DetailInputs& inputs =
-      controller()->RequestedFieldsForSection(SECTION_CC_BILLING);
   FieldValueMap outputs;
-  CopyInitialValues(inputs, &outputs);
+  CopyInitialValues(
+      controller()->RequestedFieldsForSection(SECTION_CC_BILLING),
+      &outputs);
   controller()->GetView()->SetUserInput(SECTION_CC_BILLING, outputs);
 
   for (size_t i = 0; i < arraysize(sections); ++i) {
     const DetailInputs& inputs =
         controller()->RequestedFieldsForSection(sections[i]);
     for (size_t j = 0; j < inputs.size(); ++j) {
       if (inputs[j].type == CREDIT_CARD_NUMBER ||
           inputs[j].type == CREDIT_CARD_VERIFICATION_CODE) {
         EXPECT_FALSE(controller()->InputIsEditable(inputs[j], sections[i]));
       } else {
@@ skipping 663 matching lines @@
   EXPECT_EQ(ASCIIToUTF16("United States"), form_structure()->field(2)->value);
   EXPECT_EQ(ADDRESS_HOME_COUNTRY,
             form_structure()->field(3)->Type().GetStorableType());
   EXPECT_EQ(ASCIIToUTF16("US"), form_structure()->field(3)->value);
   EXPECT_EQ(ADDRESS_HOME_COUNTRY,
             form_structure()->field(4)->Type().GetStorableType());
   EXPECT_EQ(ASCIIToUTF16("United States"), form_structure()->field(4)->value);
 }
 
 }  // namespace autofill