Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 876343004: fix autofill shadowing vars warning (Closed)

Created:
5 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 11 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix autofill shadowing vars warning found by the vc /analyze bot BUG=440500 Committed: https://crrev.com/d722c2ce033811a1dcb33d7c2fb7d1cfc7041e78 Cr-Commit-Position: refs/heads/master@{#313433}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cpu_(ooo_6.6-7.5)
these are the warnings e:\b\build\slave\chromium_windows_analyze\build\src\third_party\skia\include\core\skmath.h(82) : warning C6102: Using 'index' from failed function call at ...
5 years, 11 months ago (2015-01-28 00:44:38 UTC) #2
Ilya Sherman
LGTM % a nit. Thanks. https://codereview.chromium.org/876343004/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc (right): https://codereview.chromium.org/876343004/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc#newcode746 chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:746: for (size_t ix = ...
5 years, 11 months ago (2015-01-28 01:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876343004/20001
5 years, 11 months ago (2015-01-28 02:03:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-28 04:14:08 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 04:16:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d722c2ce033811a1dcb33d7c2fb7d1cfc7041e78
Cr-Commit-Position: refs/heads/master@{#313433}

Powered by Google App Engine
This is Rietveld 408576698