Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 876243002: Fix border painting on self-painting layers. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix border painting on self-painting layers. Commit efc3afd428bd85fd3d12e0dc941b5eb7248ca30b broke it because we'd computed an empty foreground layer. Now that background painting is part of the foreground phase, we need to use the background rect for clipping. As best I can tell, the background rect is always >= the size of the foreground rect, so it should be safe to use. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/548e122965df9d8572e7df2b1064d920528d8248

Patch Set 1 #

Patch Set 2 : rebaseline test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M sky/examples/flights-app/app-toast.sky View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tests/framework/flights-app-expected.txt View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
ojan
5 years, 11 months ago (2015-01-27 06:13:41 UTC) #2
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-27 06:31:05 UTC) #3
ojan
https://codereview.chromium.org/876243002/diff/20001/sky/tests/framework/flights-app-expected.txt File sky/tests/framework/flights-app-expected.txt (right): https://codereview.chromium.org/876243002/diff/20001/sky/tests/framework/flights-app-expected.txt#newcode141 sky/tests/framework/flights-app-expected.txt:141: layer at (609,509) size 159x59 clip at (610,510) size ...
5 years, 11 months ago (2015-01-27 06:45:23 UTC) #4
ojan
5 years, 11 months ago (2015-01-27 06:45:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
548e122965df9d8572e7df2b1064d920528d8248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698