Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 876243002: Fix border painting on self-painting layers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebaseline test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/flights-app/app-toast.sky » ('j') | sky/tests/framework/flights-app-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayer.cpp
diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp
index b842fba65ac1d35ca4c937c55c5e95a52e931cae..baf60898b5597ba2a9ac2127c3359798db264fa1 100644
--- a/sky/engine/core/rendering/RenderLayer.cpp
+++ b/sky/engine/core/rendering/RenderLayer.cpp
@@ -991,6 +991,7 @@ void RenderLayer::paintLayerContents(GraphicsContext* context, const LayerPainti
FilterEffectRendererHelper filterPainter(filterRenderer() && paintsWithFilters());
LayoutRect layerBounds;
+ // FIXME(sky): Remove foregroundRect. It's unused.
ClipRect backgroundRect, foregroundRect, outlineRect;
ClipRectsContext clipRectsContext(localPaintingInfo.rootLayer, PaintingClipRects, localPaintingInfo.subPixelAccumulation);
clipper().calculateRects(clipRectsContext, localPaintingInfo.paintDirtyRect,
@@ -1045,7 +1046,7 @@ void RenderLayer::paintLayerContents(GraphicsContext* context, const LayerPainti
if (shouldPaintContent) {
paintForeground(context, transparencyLayerContext, paintingInfo.paintDirtyRect, haveTransparency,
- localPaintingInfo, paintingRootForRenderer, layerLocation, foregroundRect);
+ localPaintingInfo, paintingRootForRenderer, layerLocation, backgroundRect);
}
paintOutline(context, localPaintingInfo, paintingRootForRenderer, layerLocation, outlineRect);
« no previous file with comments | « no previous file | sky/examples/flights-app/app-toast.sky » ('j') | sky/tests/framework/flights-app-expected.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698